Skip to content

fix(ui-form-field): make JAWS read input field labels and form error …#2011

Merged
ToMESSKa merged 1 commit into
masterfrom
INSTUI-4568-helper-text-validation-errors-will-read-the-following-field-input-label-for-the-input
Jun 6, 2025
Merged

fix(ui-form-field): make JAWS read input field labels and form error …#2011
ToMESSKa merged 1 commit into
masterfrom
INSTUI-4568-helper-text-validation-errors-will-read-the-following-field-input-label-for-the-input

Conversation

@ToMESSKa

@ToMESSKa ToMESSKa commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

…separately

INSTUI-4568

ISSUE:

  • JAWS announces input field labels and form error messages together if form error is followed by a label

TEST PLAN:

  • go to the first example in FormFieldGroup
  • with JAWS, go through the example using down and up arrow keys to read 'Invalid name' and 'Favorite Side Dish' texts
  • JAWS should announce these texts separately: first 'Invalid name', then by pressing the down arrow key 'Favorite Side Dish' (previously JAWS announced them together)
  • check the example with other screenreaders too, they should have no issues announcing them
  • compare the error messages to the current version in the 'Form Errors', 'FormField' and 'FormFieldGroup' pages, there should be no visual changes

@ToMESSKa ToMESSKa self-assigned this Jun 4, 2025
@github-actions

github-actions Bot commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-06 12:50 UTC

@ToMESSKa ToMESSKa force-pushed the INSTUI-4568-helper-text-validation-errors-will-read-the-following-field-input-label-for-the-input branch from 1480fb6 to 3e164ff Compare June 4, 2025 11:29
@ToMESSKa ToMESSKa requested review from joyenjoyer and matyasf June 4, 2025 11:44
matyasf
matyasf approved these changes Jun 6, 2025
View reviewed changes

@matyasf matyasf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely :)

@ToMESSKa ToMESSKa merged commit 9c23166 into master Jun 6, 2025
12 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4568-helper-text-validation-errors-will-read-the-following-field-input-label-for-the-input branch June 6, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToMESSKa @matyasf @joyenjoyer